cpu: native: don't handle pending signals in isr_thread_yield #6135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaspar030
added
Type: bug
|
I think I found something similar when reviewing #2071. |
|
(And in my working branch for the 1000-native-nodes experiments, I have the same diff: OlegHahm@9930e17) |
|
@LudwigKnuepfer could you take a look? Aren't IRQ's (signals) queued if not handled here? If not, we need to get rid of the cpu_switch_context_exit() call. One way would be to have a version if native_irq_handler() which does not call it. |
|
I can't estimate when I have time to investigate this properly. I would advise to try and figure it out on your own unless it can wait for at least two weeks. |
|
I cannot reproduce anymore. Reading through the description, this should be fixed by #6660. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been hitting a bug were a thread wouldn't get scheduled anymore even after putting it on the respective runqueue.
I think the problem is a possibly nested call of isr_thread_yield():
... somehow now the thread woken up by 2.) doesn't get scheduled anymore.
I don't know why (tm), but removing the pending signal handling from isr_thread_yield() solves this.